fix for reviews on string

This commit is contained in:
Metehan Tuncbilek
2024-10-19 17:05:09 +03:00
parent dfa064399e
commit 3d601d7d66

View File

@@ -96,8 +96,7 @@ namespace OpenVulkano
String Trim() noexcept
{
String trimmed = TrimBack();
return trimmed.TrimFront();
return TrimBack().TrimFront();
}
String& TrimFront() noexcept
@@ -205,7 +204,7 @@ namespace OpenVulkano
m_string.size() - end - delimiter.size()) };
}
static inline constexpr int64_t OctToInt(std::string_view string)
static inline constexpr int64_t OctToInt(const std::string_view& string)
{
int64_t result = 0;
for (int i = 0; i < static_cast<int>(string.length()); i++)
@@ -228,9 +227,9 @@ namespace OpenVulkano
return result;
}
constexpr int64_t OctToInt() { return OctToInt(m_string); }
constexpr int64_t OctToInt() const { return OctToInt(m_string); }
static inline constexpr int64_t HexToInt(std::string string)
static inline constexpr int64_t HexToInt(const std::string_view& string)
{
int64_t result = 0;
for (char c: string)
@@ -265,6 +264,11 @@ namespace OpenVulkano
constexpr int64_t HexToInt() { return HexToInt(m_string); }
bool IsUrl(const std::string_view& str)
{
return str.find("http://") == 0 || str.find("https://") == 0 || str.find("ftp://") == 0;
}
void ToUpper() noexcept
{
std::transform(m_string.begin(), m_string.end(), m_string.begin(),