From 60d3547edc5c75776bacfef65a1be7662b2126a2 Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Thu, 23 Nov 2023 23:41:55 +0100 Subject: [PATCH] Fix some warnings --- openVulkanoCpp/Scene/Shader/Shader.hpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/openVulkanoCpp/Scene/Shader/Shader.hpp b/openVulkanoCpp/Scene/Shader/Shader.hpp index bae02ed..00f4d26 100644 --- a/openVulkanoCpp/Scene/Shader/Shader.hpp +++ b/openVulkanoCpp/Scene/Shader/Shader.hpp @@ -46,9 +46,9 @@ namespace OpenVulkano::Scene ShaderProgram(ShaderProgramType type, const std::string& name) : type(type), name(name) {} - ShaderProgram(const ShaderProgram& program) : type(program.type), name(program.name) {} + ShaderProgram(const ShaderProgram& program) = default; - ShaderProgram(ShaderProgram&& program) : type(program.type), name(std::move(program.name)) {} + ShaderProgram(ShaderProgram&& program) noexcept : type(program.type), name(std::move(program.name)) {} [[nodiscard]] std::string GetShaderNameOpenGL() const { @@ -102,6 +102,8 @@ namespace OpenVulkano::Scene return *this; } +#pragma clang diagnostic push +#pragma ide diagnostic ignored "LoopDoesntUseConditionVariableInspection" Shader& AddVertexInputDescription(const VertexInputDescription& inputDescription, int bindingId = -1) { CheckShaderInitState(); @@ -110,7 +112,7 @@ namespace OpenVulkano::Scene { vertexInputDescriptions.emplace_back(0, 0); } - if (bindingId == vertexInputDescriptions.size()) + if (bindingId == static_cast(vertexInputDescriptions.size())) { vertexInputDescriptions.emplace_back(bindingId, inputDescription); } @@ -134,6 +136,7 @@ namespace OpenVulkano::Scene descriptorSets[setId].push_back(binding); return *this; } +#pragma clang diagnostic pop void Close() override {