From b47656369841a668169dc376ad9a9cb09d4c3739 Mon Sep 17 00:00:00 2001 From: Vladyslav Baranovskyi Date: Mon, 14 Oct 2024 15:20:39 +0300 Subject: [PATCH] Simplified empty string comparison, added logger reporting error --- openVulkanoCpp/IO/Archive/ArchiveReader.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/openVulkanoCpp/IO/Archive/ArchiveReader.cpp b/openVulkanoCpp/IO/Archive/ArchiveReader.cpp index fdaf1be..b8efd2e 100644 --- a/openVulkanoCpp/IO/Archive/ArchiveReader.cpp +++ b/openVulkanoCpp/IO/Archive/ArchiveReader.cpp @@ -57,8 +57,14 @@ namespace OpenVulkano bool ArchiveReader::Open(const char* archiveFile) { - if (std::string(archiveFile) == "") + if (archiveFile[0] == '\0') + { + if (m_logger) + { + m_logger->error("Unable to open archive file with an empty name!"); + } return false; + } PrepOpen(); ChkErr(archive_read_open_filename(m_archive, archiveFile, BUFFER_SIZE)); ReadNextHeader();