From d33ccd140cf04627a74ef1e26008cb0955768e6d Mon Sep 17 00:00:00 2001
From: Georg Hagen <git.georg.hagen@madvoxel.com>
Date: Sun, 2 Mar 2025 20:05:53 +0100
Subject: [PATCH] Expand logger to use filesystem path over string path in api

---
 openVulkanoCpp/Base/Logger.cpp | 6 +++---
 openVulkanoCpp/Base/Logger.hpp | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/openVulkanoCpp/Base/Logger.cpp b/openVulkanoCpp/Base/Logger.cpp
index 1b8e5a3..1987ae3 100644
--- a/openVulkanoCpp/Base/Logger.cpp
+++ b/openVulkanoCpp/Base/Logger.cpp
@@ -109,15 +109,15 @@ namespace OpenVulkano
 		}
 	}
 
-	void Logger::SetupLogger(std::string logFolder, const std::string& logFile, bool handleSignals)
+	void Logger::SetupLogger(std::filesystem::path logFolder, const std::string& logFile, bool handleSignals)
 	{
-		if (logFolder.empty()) logFolder = (AppFolders::GetAppDataHomeDir() / "logs").string();
+		if (logFolder.empty()) logFolder = AppFolders::GetAppDataHomeDir() / "logs";
 		if (!SINKS.empty()) return;
 		try
 		{
 			try
 			{
-				SINKS.push_back(std::make_shared<spdlog::sinks::rotating_file_sink_mt>(logFolder + "/" + logFile, MAX_LOG_FILE_SIZE, MAX_LOG_FILE_COUNT, true));
+				SINKS.push_back(std::make_shared<spdlog::sinks::rotating_file_sink_mt>((logFolder / logFile).string(), MAX_LOG_FILE_SIZE, MAX_LOG_FILE_COUNT, true));
 			}
 			catch (const spdlog::spdlog_ex& e)
 			{
diff --git a/openVulkanoCpp/Base/Logger.hpp b/openVulkanoCpp/Base/Logger.hpp
index b36e4a6..61ac1e2 100644
--- a/openVulkanoCpp/Base/Logger.hpp
+++ b/openVulkanoCpp/Base/Logger.hpp
@@ -35,7 +35,7 @@ namespace OpenVulkano
 		static Ptr PERF;
 		static Ptr APP;
 
-		[[deprecated]] static void SetupLogger(std::string logFolder = "", const std::string& logFile = "openVulkano.log", bool handleSignals = false);
+		static void SetupLogger(std::filesystem::path logFolder = "", const std::string& logFile = "openVulkano.log", bool handleSignals = false);
 
 		/**
 		 * \brief Creates a new custom logger that writes to the main log file.