Merge pull request 'Extend image API' (#136) from misc into master

Reviewed-on: https://git.madvoxel.net/OpenVulkano/OpenVulkano/pulls/136
Reviewed-by: Georg Hagen <georg.hagen@madvoxel.com>
This commit is contained in:
Oleksii_Hyzha
2024-10-07 19:24:57 +02:00
6 changed files with 49 additions and 1 deletions

View File

@@ -60,4 +60,16 @@ namespace OpenVulkano::Image
stbi_image_free(pixelData); stbi_image_free(pixelData);
return std::make_unique<Image>(std::move(result)); return std::make_unique<Image>(std::move(result));
} }
Math::Vector2i IImageLoader::GetDimensionsInternal(const std::string& filename)
{
Math::Vector2i res = {};
int channels;
if (!stbi_info(filename.c_str(), &res.x, &res.y, &channels))
{
Logger::FILESYS->error("Failed to read image header of file {}", filename);
return Math::Vector2i{ -1, -1 };
}
return res;
}
} }

View File

@@ -21,5 +21,8 @@ namespace OpenVulkano::Image
static std::unique_ptr<Image> loadData(const uint8_t* data, int size, int desiredChannels = 0); static std::unique_ptr<Image> loadData(const uint8_t* data, int size, int desiredChannels = 0);
virtual std::unique_ptr<Image> loadFromFile(const std::string& filePath) = 0; virtual std::unique_ptr<Image> loadFromFile(const std::string& filePath) = 0;
virtual std::unique_ptr<Image> loadFromMemory(const std::vector<uint8_t>& buffer) = 0; virtual std::unique_ptr<Image> loadFromMemory(const std::vector<uint8_t>& buffer) = 0;
virtual Math::Vector2i GetImageDimensions(const std::string& filename) = 0;
protected:
static Math::Vector2i GetDimensionsInternal(const std::string& filename);
}; };
} }

View File

@@ -31,6 +31,33 @@ namespace OpenVulkano::Image
return loadJpeg(buffer.data(), buffer.size()); return loadJpeg(buffer.data(), buffer.size());
} }
Math::Vector2i ImageLoaderJpeg::GetImageDimensions(const std::string& filename)
{
#if __has_include("turbojpeg.h")
auto image = Utils::ReadFile(filename);
tjhandle jpegDecompressor = tjInitDecompress();
if (!jpegDecompressor)
{
Logger::FILESYS->error("Failed to read jpeg header. Error: {}", tjGetErrorStr());
return Math::Vector2i { -1, -1 };
}
Math::Vector2i res = {};
int size = 0, jpegSubsamp = 0;
int status = tjDecompressHeader2(jpegDecompressor, reinterpret_cast<unsigned char*>(image.Data()), image.Size(),
&res.x, &res.y, &jpegSubsamp);
if (status != 0)
{
Logger::FILESYS->error("Failed to read jpeg header. Error: {}", tjGetErrorStr());
tjDestroy(jpegDecompressor);
return Math::Vector2i { -1, -1 };
}
tjDestroy(jpegDecompressor);
return res;
#else
return IImageLoader::GetDimensionsInternal(filename);
#endif
}
std::unique_ptr<Image> ImageLoaderJpeg::loadJpeg(const uint8_t* data, size_t size) std::unique_ptr<Image> ImageLoaderJpeg::loadJpeg(const uint8_t* data, size_t size)
{ {
#if __has_include("turbojpeg.h") #if __has_include("turbojpeg.h")

View File

@@ -15,7 +15,7 @@ namespace OpenVulkano::Image
public: public:
std::unique_ptr<Image> loadFromFile(const std::string& filePath) override; std::unique_ptr<Image> loadFromFile(const std::string& filePath) override;
std::unique_ptr<Image> loadFromMemory(const std::vector<uint8_t>& buffer) override; std::unique_ptr<Image> loadFromMemory(const std::vector<uint8_t>& buffer) override;
Math::Vector2i GetImageDimensions(const std::string& filename) override;
private: private:
std::unique_ptr<Image> loadJpeg(const uint8_t* data, size_t size); std::unique_ptr<Image> loadJpeg(const uint8_t* data, size_t size);
}; };

View File

@@ -22,4 +22,9 @@ namespace OpenVulkano::Image
{ {
return loadData(buffer.data(), static_cast<int>(buffer.size())); return loadData(buffer.data(), static_cast<int>(buffer.size()));
} }
Math::Vector2i ImageLoaderPng::GetImageDimensions(const std::string& filename)
{
return GetDimensionsInternal(filename);
}
} }

View File

@@ -15,5 +15,6 @@ namespace OpenVulkano::Image
public: public:
std::unique_ptr<Image> loadFromFile(const std::string& filePath) override; std::unique_ptr<Image> loadFromFile(const std::string& filePath) override;
std::unique_ptr<Image> loadFromMemory(const std::vector<uint8_t>& buffer) override; std::unique_ptr<Image> loadFromMemory(const std::vector<uint8_t>& buffer) override;
Math::Vector2i GetImageDimensions(const std::string& filename) override;
}; };
} }