GeorgH93/OpenVulkano
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix some warnings

Browse Source
This commit is contained in:
GeorgH93
2023-11-23 23:41:55 +01:00
parent 5393f2101a
commit 60d3547edc
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
openVulkanoCpp/Scene/Shader/Shader.hpp
View File

@@ -46,9 +46,9 @@ namespace OpenVulkano::Scene
ShaderProgram(ShaderProgramType type, const std::string& name) : type(type), name(name) {} ShaderProgram(ShaderProgramType type, const std::string& name) : type(type), name(name) {}
ShaderProgram(const ShaderProgram& program) : type(program.type), name(program.name) {} ShaderProgram(const ShaderProgram& program) = default;
ShaderProgram(ShaderProgram&& program) : type(program.type), name(std::move(program.name)) {} ShaderProgram(ShaderProgram&& program) noexcept : type(program.type), name(std::move(program.name)) {}
[[nodiscard]] std::string GetShaderNameOpenGL() const [[nodiscard]] std::string GetShaderNameOpenGL() const
{ {
@@ -102,6 +102,8 @@ namespace OpenVulkano::Scene
return *this; return *this;
} }
#pragma clang diagnostic push
#pragma ide diagnostic ignored "LoopDoesntUseConditionVariableInspection"
Shader& AddVertexInputDescription(const VertexInputDescription& inputDescription, int bindingId = -1) Shader& AddVertexInputDescription(const VertexInputDescription& inputDescription, int bindingId = -1)
{ {
CheckShaderInitState(); CheckShaderInitState();
@@ -110,7 +112,7 @@ namespace OpenVulkano::Scene
{ {
vertexInputDescriptions.emplace_back(0, 0); vertexInputDescriptions.emplace_back(0, 0);
} }
if (bindingId == vertexInputDescriptions.size()) if (bindingId == static_cast<int>(vertexInputDescriptions.size()))
{ {
vertexInputDescriptions.emplace_back(bindingId, inputDescription); vertexInputDescriptions.emplace_back(bindingId, inputDescription);
} }
@@ -134,6 +136,7 @@ namespace OpenVulkano::Scene
descriptorSets[setId].push_back(binding); descriptorSets[setId].push_back(binding);
return *this; return *this;
} }
#pragma clang diagnostic pop
void Close() override void Close() override
{ {