GeorgH93/OpenVulkano
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Expand logger to use filesystem path over string path in api

Browse Source
This commit is contained in:
Georg Hagen
2025-03-02 20:05:53 +01:00
parent 950c66f5c8
commit d33ccd140c
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
openVulkanoCpp/Base/Logger.cpp
View File

@@ -109,15 +109,15 @@ namespace OpenVulkano
} }
} }
void Logger::SetupLogger(std::string logFolder, const std::string& logFile, bool handleSignals) void Logger::SetupLogger(std::filesystem::path logFolder, const std::string& logFile, bool handleSignals)
{ {
if (logFolder.empty()) logFolder = (AppFolders::GetAppDataHomeDir() / "logs").string(); if (logFolder.empty()) logFolder = AppFolders::GetAppDataHomeDir() / "logs";
if (!SINKS.empty()) return; if (!SINKS.empty()) return;
try try
{ {
try try
{ {
SINKS.push_back(std::make_shared<spdlog::sinks::rotating_file_sink_mt>(logFolder + "/" + logFile, MAX_LOG_FILE_SIZE, MAX_LOG_FILE_COUNT, true)); SINKS.push_back(std::make_shared<spdlog::sinks::rotating_file_sink_mt>((logFolder / logFile).string(), MAX_LOG_FILE_SIZE, MAX_LOG_FILE_COUNT, true));
} }
catch (const spdlog::spdlog_ex& e) catch (const spdlog::spdlog_ex& e)
{ {

2
openVulkanoCpp/Base/Logger.hpp
View File

@@ -35,7 +35,7 @@ namespace OpenVulkano
static Ptr PERF; static Ptr PERF;
static Ptr APP; static Ptr APP;
[[deprecated]] static void SetupLogger(std::string logFolder = "", const std::string& logFile = "openVulkano.log", bool handleSignals = false); static void SetupLogger(std::filesystem::path logFolder = "", const std::string& logFile = "openVulkano.log", bool handleSignals = false);
/** /**
* \brief Creates a new custom logger that writes to the main log file. * \brief Creates a new custom logger that writes to the main log file.