review refactors

This commit is contained in:
Metehan Tuncbilek
2024-07-16 18:31:43 +03:00
parent ac1c5f20ec
commit dbd7b2dad5
6 changed files with 79 additions and 71 deletions

View File

@@ -70,19 +70,10 @@ namespace OpenVulkano
throw std::runtime_error("Failed to open file '" + filePath + "'!");
}
const size_t fileSize = static_cast<size_t>(file.tellg());
if (nullTerminateString)
{
Array<char> data(fileSize + 1);
file.seekg(0);
file.read(data.Data(), fileSize);
data[fileSize] = '\0';
file.close();
return data;
}
Array<char> data(fileSize);
Array<char> data(fileSize + nullTerminateString);
file.seekg(0);
file.read(data.Data(), fileSize);
if (nullTerminateString) data[fileSize] = '\0';
file.close();
return data;
}